-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Hugo to 0.107.0 #2403
Upgrade Hugo to 0.107.0 #2403
Conversation
@danielramirez0 I think I've got this pretty well working. Main thing left is I will be updating the README to reflect the new version changes and other details. We can look at this together next week and we should socialize to TDC Slack channels for folks who build locally as they will need to do some brew upgrades, etc. |
Makefile
Outdated
@echo hugo $(hugo_local) validated | ||
else | ||
@echo $@ failure: Your hugo version \($(hugo_local)\) does not match production \($(hugo_prod)\) | ||
@echo run \'make hugo-update\' or \'brew upgrade hugo\' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryanfriedman Haven't written the rule for hugo-update yet, but also may not need if we just direct them to upgrade via brew manually. Also had an idea to write a rule for automating the prerequisite stuff for new (and maybe even existing) contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I think we should avoid trying to auto install or update hugo for now. It could get pretty hairy as we'd have to check if they're on a Mac, what version they have to see if we have to install or upgrade, etc. The logic is doable but complex so I think we just change the message to say use brew upgrade or brew install or wget etc. for now.
This PR upgrades hugo, Node and some related GitHub actions. Here is a list of specific changes:
/developer
to all relative links, so we had to update our codebase to reflect the new behavior. This represents the bulk of the changes.tweet
shortcode must include username and .Path should use .File.Path).