Manage poi access points in journeys #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2023 16:53
azime
changed the title
pbench
reviewed
Apr 18, 2023
source/jormungandr/jormungandr/scenarios/helper_classes/helper_utils.py
Outdated
Show resolved
Hide resolved
pbench
reviewed
Apr 18, 2023
source/jormungandr/jormungandr/scenarios/helper_classes/helper_utils.py
Outdated
Show resolved
Hide resolved
pbench
reviewed
Apr 18, 2023
Comment on lines
+377
to
+379
| poi_access = fallback_sections[-1].vias.add() | ||
| else: | ||
| poi_access = fallback_sections[0].vias.add() |
There was a problem hiding this comment.
you don't care about the order of the poi_access objects in the vias list ?
There was a problem hiding this comment.
the important via_uri in path
added 2 commits
April 18, 2023 15:48
pbench
approved these changes
Apr 18, 2023
xlqian
reviewed
Apr 18, 2023
Comment on lines
320
to
327
| self._requested_place_obj.embedded_type == type_pb2.POI | ||
| and self._mode | ||
| in [ | ||
| FallbackModes.walking.name, | ||
| FallbackModes.bike.name, | ||
| ] | ||
| and self._requested_place_obj.poi.children | ||
| and self._request.get("_poi_access_points", False) |
There was a problem hiding this comment.
Suggested change
| self._requested_place_obj.embedded_type == type_pb2.POI | |
| and self._mode | |
| in [ | |
| FallbackModes.walking.name, | |
| FallbackModes.bike.name, | |
| ] | |
| and self._requested_place_obj.poi.children | |
| and self._request.get("_poi_access_points", False) | |
| self._request.get("_poi_access_points", False) | |
| and self._requested_place_obj.embedded_type == type_pb2.POI | |
| and self._mode | |
| in [ | |
| FallbackModes.walking.name, | |
| FallbackModes.bike.name, | |
| ] | |
| and self._requested_place_obj.poi.children |
| @@ -54,7 +54,8 @@ | |||
|
|
|||
| # use dataclass when python3.7 is available | |||
| DurationElement = namedtuple( | |||
| 'DurationElement', ['duration', 'status', 'car_park', 'car_park_crowfly_duration', 'via_access_point'] | |||
| 'DurationElement', | |||
| ['duration', 'status', 'car_park', 'car_park_crowfly_duration', 'via_access_point', 'via_poi_access'], | |||
There was a problem hiding this comment.
is it possible to rename via_access_point to via_pt_access?
Suggested change
| ['duration', 'status', 'car_park', 'car_park_crowfly_duration', 'via_access_point', 'via_poi_access'], | |
| ['duration', 'status', 'car_park', 'car_park_crowfly_duration', 'via_pt_access', 'via_poi_access'], |
| centers_isochrone = self._determine_centers_isochrone() | ||
| result = [] | ||
| for center_isochrone in centers_isochrone: | ||
| result.append( |
There was a problem hiding this comment.
💡 could be parallelized later, if necessary
Comment on lines
385
to
393
| best_duration = element.duration | ||
| best_element = DurationElement( | ||
| element.duration, | ||
| element.status, | ||
| element.car_park, | ||
| element.car_park_crowfly_duration, | ||
| element.via_access_point, | ||
| centers_isochrone[index], | ||
| ) |
There was a problem hiding this comment.
Suggested change
| best_duration = element.duration | |
| best_element = DurationElement( | |
| element.duration, | |
| element.status, | |
| element.car_park, | |
| element.car_park_crowfly_duration, | |
| element.via_access_point, | |
| centers_isochrone[index], | |
| ) | |
| best_duration = element.duration | |
| best_element = copy.deepcopy(element) | |
| best_element.via_poi_access = centers_isochrone[index] |
There was a problem hiding this comment.
best_element is a namedtuple, you can't change a value
added 2 commits
April 18, 2023 17:57
xlqian
approved these changes
Apr 18, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.