[Jormungandr] monitor jormungandr #4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbougue
approved these changes
Sep 25, 2023
| @@ -49,6 +49,6 @@ RUN a2ensite 000-default.conf \ | |||
|
|
|||
| HEALTHCHECK CMD curl -f http://localhost/v1 || exit 1 | |||
|
|
|||
| EXPOSE 80 | |||
| EXPOSE 80 9091 | |||
There was a problem hiding this comment.
OK, so not using apache on the new health endpoint.
There was a problem hiding this comment.
I'm asking myself if you should not also specify the port 5050 which is exposed for uwsgi stats.
docker/run_jormungandr.sh
Outdated
| @@ -1,14 +1,27 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| app_processes=${1-1} | |||
There was a problem hiding this comment.
So first arg, and default value is 1.
❤️ bash
pbougue
reviewed
Sep 26, 2023
docker/run_jormungandr.sh
Outdated
| function show_help() { | ||
| cat << EOF | ||
| Usage: ${0##*/} -j jormungandr-processes -m monitor-processes -r max-requests | ||
| -j jormungandr-processes |
There was a problem hiding this comment.
below, the naming is app_processes:
Suggested change
| -j jormungandr-processes | |
| -a app-processes number |
docker/run_jormungandr.sh
Outdated
| cat << EOF | ||
| Usage: ${0##*/} -j jormungandr-processes -m monitor-processes -r max-requests | ||
| -j jormungandr-processes | ||
| -m [0|1] monitor-processes |
There was a problem hiding this comment.
Suggested change
| -m [0|1] monitor-processes | |
| -m [0|1] activate monitor-process |
Aletor93
approved these changes
Sep 26, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: NAV-2329