New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker] jormungandr-processes param removed #4116

Merged

azime merged 2 commits into dev from remove_uwsgi_processes_arg

Sep 27, 2023

Contributor

azime commented Sep 27, 2023 •

edited by pbougue

Loading

Follow-up on #4112

I leave this variable among the environment variables only to avoid params overlap


          jormungandr-processes param removed

2681b9d

azime requested review from xlqian and pbougue

September 27, 2023 10:38

pbougue approved these changes

View reviewed changes

Contributor

pbougue left a comment •

edited

Loading

Why do you remove this ?
Is it because it duplicates another param and can be misleading ?

OK, edited main comment ✔️

docker/run_jormungandr.sh Outdated

@@ @@ -7,17 +7,14 @@ monitor_cache2="name=monitor,items=100" @@
               function show_help() {
                   cat << EOF
-              Usage: ${0##*/} -a jormungandr-processes -m monitor-processes -r max-requests
-                  -a      app-processes number
+              Usage: ${0##*/} -m monitor-processes -r max-requests

Contributor

pbougue Sep 27, 2023

very minor:

Suggested change

      
            Usage: ${0##*/} -m monitor-processes -r max-requests
          
            Usage: ${0##*/} -m monitor-process -r max-requests


          Corrections

0fbd7aa

xlqian approved these changes

View reviewed changes

sonarqubecloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

azime merged commit 8cf7396 into dev

azime deleted the remove_uwsgi_processes_arg branch

September 27, 2023 13:36

pbougue changed the title ~~jormungandr-processes param removed~~ [docker] jormungandr-processes param removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet