Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Introduce AWSMachine and AWSCluster feature gates #5284

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

✨ Introduce AWSMachine and AWSCluster feature gates #5284

wants to merge 2 commits into from
+136 −21

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Jan 15, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Added AWSMachine and AWSCluster feature flags to control AWSMachineReconciler and AWSClusterReconciler.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mzazrivec. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 15, 2025
@mzazrivec mzazrivec changed the title ✨ Introduce AWSMachine and AWSCluster feature gates ✨ WIP: Introduce AWSMachine and AWSCluster feature gates Jan 15, 2025
fiunchinho
fiunchinho reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add tests?

serngawy
serngawy reviewed Jan 20, 2025
View reviewed changes
@mzazrivec mzazrivec force-pushed the aws_self_managed_granularity_switches branch from bbe29d0 to 6dbdfb1 Compare January 29, 2025 10:52
@mzazrivec
Copy link
Contributor Author

Would it be possible to add tests?

While I understand the utility and usefulness of tests, creating tests for the feature gates would require changing main.go, maybe other files too (i.e. there are no tests for feature gates yet). Since this pull request implements the proposal from #5276 I really want to avoid any further changes here.

@serngawy
Copy link
Contributor

Would it be possible to add tests?

While I understand the utility and usefulness of tests, creating tests for the feature gates would require changing main.go, maybe other files too (i.e. there are no tests for feature gates yet). Since this pull request implements the proposal from #5276 I really want to avoid any further changes here.

You may update the e2e test to check for the feature-gate is enbaled/disabled similar to AlternativeGCStrategy test

serngawy
serngawy suggested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@serngawy serngawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2025
@mzazrivec mzazrivec force-pushed the aws_self_managed_granularity_switches branch from 6dbdfb1 to 5bd80bf Compare February 11, 2025 16:05
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2025
@mzazrivec mzazrivec force-pushed the aws_self_managed_granularity_switches branch from 5bd80bf to cbe57a3 Compare February 13, 2025 20:41
@damdo damdo added this to the v2.8 milestone Feb 14, 2025
@mzazrivec
Copy link
Contributor Author

/retest

@mzazrivec mzazrivec force-pushed the aws_self_managed_granularity_switches branch 4 times, most recently from d2f72ce to 65eb771 Compare February 19, 2025 15:18
@mzazrivec mzazrivec changed the title ✨ WIP: Introduce AWSMachine and AWSCluster feature gates ✨ Introduce AWSMachine and AWSCluster feature gates Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 20, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 20, 2025
damdo
damdo reviewed Feb 20, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @mzazrivec @serngawy
It looks reasonable to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@damdo
Copy link
Member

damdo commented Feb 20, 2025

/unlgtm

@damdo
Copy link
Member

damdo commented Feb 20, 2025

/assign @richardcase @nrb @dlipovetsky @AndiDog

For approver review

@mzazrivec mzazrivec force-pushed the aws_self_managed_granularity_switches branch from 65eb771 to 4bb5a08 Compare February 20, 2025 19:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andidog. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

damdo
damdo reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2025
@damdo
Copy link
Member

damdo commented Feb 27, 2025

/assign @nrb

@richardcase
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-gc

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e

@mzazrivec
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@mzazrivec: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e 4bb5a08 link false /test pull-cluster-api-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiunchinho fiunchinho fiunchinho left review comments

@damdo damdo damdo left review comments

@serngawy serngawy serngawy approved these changes

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees

@richardcase richardcase

@nrb nrb

@AndiDog AndiDog

@dlipovetsky dlipovetsky

@damdo damdo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v2.8
Development

Successfully merging this pull request may close these issues.
9 participants
@mzazrivec @k8s-ci-robot @serngawy @damdo @richardcase @fiunchinho @nrb @AndiDog @dlipovetsky