Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add ability to give tls certificates to metrics server #4385

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

WIP: add ability to give tls certificates to metrics server #4385

wants to merge 11 commits into from
+189 −11

Conversation

kannon92
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add a way to give tls certificates to metrics server

Which issue(s) this PR fixes:

Fixes #4377

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allow one to configure certificates for metrics

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 24, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 24, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 1e267ec
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67c22a05471ff900082e94ca
😎 Deploy Preview https://deploy-preview-4385--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kannon92
Copy link
Contributor Author

/hold

Need to update helm chart and get consensus on this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2025
@kannon92 kannon92 force-pushed the test-prometheus-cert branch from 96283f3 to 36970f6 Compare February 24, 2025 22:16
@kannon92 kannon92 mentioned this pull request Feb 25, 2025
Open
@mimowo
Copy link
Contributor

mimowo commented Feb 26, 2025

/assign

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92
Once this PR has been reviewed and has the lgtm label, please ask for approval from mimowo. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2025
@kannon92 kannon92 force-pushed the test-prometheus-cert branch from f234fb3 to 15bb5d5 Compare February 27, 2025 03:03
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2025
@kannon92 kannon92 force-pushed the test-prometheus-cert branch from 15bb5d5 to 1529104 Compare February 27, 2025 12:33
@mimowo
Copy link
Contributor

mimowo commented Feb 28, 2025

/retitle WIP: add ability to give tls certificates to metrics server

It seems like WIP since it is not aligned with KEP.

@k8s-ci-robot k8s-ci-robot changed the title add ability to give tls certificates to metrics server WIP: add ability to give tls certificates to metrics server Feb 28, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2025
@kannon92
Copy link
Contributor Author

/retitle WIP: add ability to give tls certificates to metrics server

It seems like WIP since it is not aligned with KEP.

I updated it to match what we suggested in the KEP. It is still WIP as I need to test and verify helm changes.

@kannon92 kannon92 force-pushed the test-prometheus-cert branch from d800d9a to a489a49 Compare February 28, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@gabesaba gabesaba Awaiting requested review from gabesaba

Assignees

@mimowo mimowo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow one to use cert manager to secure prometheus endpoints
3 participants
@kannon92 @mimowo @k8s-ci-robot