Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics service to deployments and fix prometheus and helm #4443

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kannon92
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

a) Add metric ports to deployments for both kustomize and helm.
b) Fix prometheus so it does not assume prometheus is deployed in the kueue namespace.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I found this issue because I was having trouble getting my kind cluster to find my metrics service.

It turns out that we were not binding the metrics service to the deployment.

This was found by checking the endpoints of kueue-controller-metrics-service and seeing that it was in fact not being used.

When we dropped kube-rbac-proxy, we dropped the creation of the metrics in the deployment spec.

I don't think this a regression as we dropped kube-rbac-proxy for 0.11. 0.10 seems to be fine.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2025
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit bf40b6c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67c21760bfb53b0008d97041
😎 Deploy Preview https://deploy-preview-4443--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants