Add metrics service to deployments and fix prometheus and helm #4443
+27
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
a) Add metric ports to deployments for both kustomize and helm.
b) Fix prometheus so it does not assume prometheus is deployed in the kueue namespace.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I found this issue because I was having trouble getting my kind cluster to find my metrics service.
It turns out that we were not binding the metrics service to the deployment.
This was found by checking the endpoints of
kueue-controller-metrics-service
and seeing that it was in fact not being used.When we dropped kube-rbac-proxy, we dropped the creation of the metrics in the deployment spec.
I don't think this a regression as we dropped kube-rbac-proxy for 0.11. 0.10 seems to be fine.
Does this PR introduce a user-facing change?