Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics service to deployments and fix prometheus and helm #4443

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/kueue/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,4 @@ The following table lists the configurable parameters of the kueue chart and the
| `managerConfig.controllerManagerConfigYaml` | controllerManagerConfigYaml | abbr. |
| `metricsService` | metricsService's ports | abbr. |
| `webhookService` | webhookService's ports | abbr. |
| `metrics.prometheusNamespace` | prometheus namespace | `monitoring` |
3 changes: 3 additions & 0 deletions charts/kueue/templates/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ spec:
- containerPort: 9443
name: webhook-server
protocol: TCP
- containerPort: 8443
name: metrics
protocol: TCP
readinessProbe:
httpGet:
path: /readyz
Expand Down
4 changes: 2 additions & 2 deletions charts/kueue/templates/prometheus/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ roleRef:
subjects:
- kind: ServiceAccount
name: prometheus-k8s
namespace: '{{ .Release.Namespace }}'
namespace: '{{ .Values.metrics.prometheusNamespace }}'
- kind: ServiceAccount
name: prometheus-operator
namespace: '{{ .Release.Namespace }}'
namespace: '{{ .Values.metrics.prometheusNamespace }}'
{{- end }}
3 changes: 3 additions & 0 deletions charts/kueue/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -153,3 +153,6 @@ webhookService:

# kueue-viz dashboard
enableKueueViz: false

metrics:
prometheusNamespace: monitoring
3 changes: 3 additions & 0 deletions config/default/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ patches:
# Expose port used by the visibility server
- path: manager_visibility_patch.yaml

# Expose port used by the metrics service
- path: manager_metrics_patch.yaml

# [CERTMANAGER] To enable cert-manager, uncomment all sections with 'CERTMANAGER'.
# Uncomment 'CERTMANAGER' sections in crd/kustomization.yaml to enable the CA injection in the admission webhooks.
# 'CERTMANAGER' needs to be enabled to use ca injection
Expand Down
15 changes: 15 additions & 0 deletions config/default/manager_metrics_patch.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# This patch exposes 8443 port used by metrics service
apiVersion: apps/v1
kind: Deployment
metadata:
name: controller-manager
namespace: system
spec:
template:
spec:
containers:
- name: manager
ports:
- containerPort: 8443
name: metrics
protocol: TCP