Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support background layer type on globe with terrain3d #4972

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 3, 2024

Towards

This is a PR mainly for the background layer.

The circle render tests, which uses the background, confirm that the circle layer is also working as expected.
The line render tests are just cleaned up a bit - they had some unused "fill" sources.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.76%. Comparing base (e4760d0) to head (22b8f66).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4972      +/-   ##
==========================================
+ Coverage   90.67%   90.76%   +0.08%     
==========================================
  Files         266      266              
  Lines       38170    38174       +4     
  Branches     3208     3184      -24     
==========================================
+ Hits        34610    34647      +37     
+ Misses       2611     2578      -33     
  Partials      949      949              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@birkskyum birkskyum marked this pull request as draft November 3, 2024 22:02
@birkskyum birkskyum marked this pull request as ready for review November 3, 2024 22:06
@birkskyum birkskyum force-pushed the support-background-on-globe-with-terrain branch from c994e94 to a82f9e8 Compare November 3, 2024 22:12
@birkskyum birkskyum mentioned this pull request Nov 3, 2024
1 task
@birkskyum birkskyum changed the title Support background layer type on globe with terrain3d Support background and circle layer type on globe with terrain3d Nov 4, 2024
@birkskyum birkskyum changed the title Support background and circle layer type on globe with terrain3d Support background ayer type on globe with terrain3d Nov 4, 2024
@birkskyum birkskyum changed the title Support background ayer type on globe with terrain3d Support background layer type on globe with terrain3d Nov 4, 2024
@birkskyum
Copy link
Member Author

closed in favor of #4977

@birkskyum birkskyum closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants