Support hillshade
layer in globe with terrain
#4976
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards
This adds support for the
hillshade
layers in globe+terrain mode.It can be merged independently of
background
layer type on globe with terrain3d #4972Working on this, I did notice there's still a problem with the fog breaking the globe+terrain mode. The workaround implemented makes the fog color transparent, but is the
sky
isn't set in the style it ends up making the entire terrain transparent. I made a better solution that passes the globeMode bool to the terrain.frag shader, and simply disables the fog logic in globe mode instead.Closes #4928
CHANGELOG.md
under the## main
section.