Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hillshade layer in globe with terrain #4976

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 4, 2024

Towards

This adds support for the hillshade layers in globe+terrain mode.

It can be merged independently of

Working on this, I did notice there's still a problem with the fog breaking the globe+terrain mode. The workaround implemented makes the fog color transparent, but is the sky isn't set in the style it ends up making the entire terrain transparent. I made a better solution that passes the globeMode bool to the terrain.frag shader, and simply disables the fog logic in globe mode instead.

Closes #4928

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.45%. Comparing base (e4760d0) to head (7a7ca42).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4976      +/-   ##
==========================================
- Coverage   90.67%   90.45%   -0.22%     
==========================================
  Files         266      266              
  Lines       38170    38178       +8     
  Branches     3208     3153      -55     
==========================================
- Hits        34610    34535      -75     
- Misses       2611     2687      +76     
- Partials      949      956       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@birkskyum birkskyum force-pushed the Support-hillshade-rendering-in-globe-with-terrain branch from b73d035 to f053323 Compare November 4, 2024 03:12
@birkskyum
Copy link
Member Author

closed in favor of #4977

@birkskyum birkskyum closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The unsupported Fog/Horizon is isn't disabled properly on Globe with Terrain3D
2 participants