Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor camera helper to split the logic for vertical-perspective and mercator #5162

Merged
merged 5 commits into from
Dec 6, 2024

Fix according to code review

584beb2
Select commit
Loading
Failed to load commit list.
Merged

Refactor camera helper to split the logic for vertical-perspective and mercator #5162

Fix according to code review
584beb2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 6, 2024 in 1s

76.50% of diff hit (target 91.79%)

View this Pull Request on Codecov

76.50% of diff hit (target 91.79%)

Annotations

Check warning on line 195 in src/geo/projection/camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/camera_helper.ts#L193-L195 

Added lines #L193 - L195 were not covered by tests

Check warning on line 37 in src/geo/projection/globe_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_camera_helper.ts#L37 

Added line #L37 was not covered by tests

Check warning on line 41 in src/geo/projection/globe_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_camera_helper.ts#L41 

Added line #L41 was not covered by tests

Check warning on line 45 in src/geo/projection/globe_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_camera_helper.ts#L45 

Added line #L45 was not covered by tests

Check warning on line 43 in src/geo/projection/projection_factory.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/projection_factory.ts#L43 

Added line #L43 was not covered by tests

Check warning on line 45 in src/geo/projection/projection_factory.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/projection_factory.ts#L45 

Added line #L45 was not covered by tests

Check warning on line 27 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L23-L27 

Added lines #L23 - L27 were not covered by tests

Check warning on line 36 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L31-L36 

Added lines #L31 - L36 were not covered by tests

Check warning on line 41 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L40-L41 

Added lines #L40 - L41 were not covered by tests

Check warning on line 48 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L43-L48 

Added lines #L43 - L48 were not covered by tests

Check warning on line 52 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L50-L52 

Added lines #L50 - L52 were not covered by tests

Check warning on line 74 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L65-L74 

Added lines #L65 - L74 were not covered by tests

Check warning on line 78 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L76-L78 

Added lines #L76 - L78 were not covered by tests

Check warning on line 91 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L81-L91 

Added lines #L81 - L91 were not covered by tests

Check warning on line 95 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L94-L95 

Added lines #L94 - L95 were not covered by tests

Check warning on line 98 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L98 

Added line #L98 was not covered by tests

Check warning on line 105 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L100-L105 

Added lines #L100 - L105 were not covered by tests

Check warning on line 109 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L108-L109 

Added lines #L108 - L109 were not covered by tests

Check warning on line 114 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L112-L114 

Added lines #L112 - L114 were not covered by tests

Check warning on line 117 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L116-L117 

Added lines #L116 - L117 were not covered by tests

Check warning on line 123 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L119-L123 

Added lines #L119 - L123 were not covered by tests

Check warning on line 129 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L127-L129 

Added lines #L127 - L129 were not covered by tests

Check warning on line 136 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L134-L136 

Added lines #L134 - L136 were not covered by tests

Check warning on line 138 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L138 

Added line #L138 was not covered by tests

Check warning on line 202 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L200-L202 

Added lines #L200 - L202 were not covered by tests
View more details on Codecov