Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor camera helper to split the logic for vertical-perspective and mercator #5162

Merged
merged 5 commits into from
Dec 6, 2024

Fix according to code review

584beb2
Select commit
Loading
Failed to load commit list.
Merged

Refactor camera helper to split the logic for vertical-perspective and mercator #5162

Fix according to code review
584beb2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 6, 2024 in 1s

91.80% (+0.01%) compared to dda90d8

View this Pull Request on Codecov

91.80% (+0.01%) compared to dda90d8

Details

Codecov Report

Attention: Patch coverage is 76.50131% with 90 lines in your changes missing coverage. Please review.

Project coverage is 91.80%. Comparing base (dda90d8) to head (584beb2).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...o/projection/vertical_perspective_camera_helper.ts 73.63% 82 Missing ⚠️
src/geo/projection/camera_helper.ts 94.00% 3 Missing ⚠️
src/geo/projection/globe_camera_helper.ts 82.35% 3 Missing ⚠️
src/geo/projection/projection_factory.ts 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@                    Coverage Diff                    @@
##           projection-expression    #5162      +/-   ##
=========================================================
+ Coverage                  91.79%   91.80%   +0.01%     
=========================================================
  Files                        280      281       +1     
  Lines                      38749    38824      +75     
  Branches                    6754     6740      -14     
=========================================================
+ Hits                       35569    35644      +75     
+ Misses                      3052     3048       -4     
- Partials                     128      132       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov