Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow metrics instruments to be cloned #280

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Allow metrics instruments to be cloned #280

merged 2 commits into from
Oct 17, 2020

Conversation

jtescher
Copy link
Member

Allow metrics to be cloned and synchronized (e.g. for use in actix-web workers)

@jtescher jtescher requested a review from a team October 17, 2020 02:09
Copy link
Member

@frigus02 frigus02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not used metrics, yet, so I'm not sure why this is needed. I also don't see that it harms anything. So 👍 🙂

@jtescher jtescher merged commit 45b0965 into master Oct 17, 2020
@jtescher jtescher deleted the clone-instruments branch October 17, 2020 17:21
markdingram added a commit to markdingram/opentelemetry-rust that referenced this pull request Jan 12, 2021
markdingram added a commit to markdingram/opentelemetry-rust that referenced this pull request Jan 12, 2021
- open-telemetry#280 previously added this to sync instruments
markdingram added a commit to markdingram/opentelemetry-rust that referenced this pull request Jan 12, 2021
- previously applied to sync instruments in open-telemetry#280
jtescher pushed a commit that referenced this pull request Jan 13, 2021
- previously applied to sync instruments in #280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants