Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Send + Sync to Async instruments (metrics) #422

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

markdingram
Copy link
Contributor

- previously applied to sync instruments in open-telemetry#280
@markdingram markdingram requested a review from a team January 12, 2021 19:13
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #422 (d8ba96c) into master (37b64b4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   48.34%   48.32%   -0.02%     
==========================================
  Files          65       65              
  Lines        5502     5502              
==========================================
- Hits         2660     2659       -1     
- Misses       2842     2843       +1     
Impacted Files Coverage Δ
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 76.76% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b64b4...d8ba96c. Read the comment docs.

@jtescher jtescher merged commit f00c4c2 into open-telemetry:master Jan 13, 2021
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some places in sdk uses Arc<dyn AsyncInstrumentCore + Send + Sync> now. Could simplify it to Arc<dyn AsyncInstrumentCore>
For example,

struct AsyncInstrumentState {
/// runners maintains the set of runners in the order they were
/// registered.
runners: Vec<(
AsyncRunner,
Arc<dyn sdk_api::AsyncInstrumentCore + Send + Sync>,
)>,
}

@jtescher
Copy link
Member

@TommyCpp good catch, yeah those should get cleaned up.

@markdingram
Copy link
Contributor Author

@TommyCpp good catch, yeah those should get cleaned up.

Happy to do this!

@markdingram markdingram deleted the async_instruments branch January 13, 2021 08:18
@markdingram markdingram restored the async_instruments branch January 13, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants