Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Send + Sync to InstrumentCore (metrics) #423

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

markdingram
Copy link
Contributor

  • removes superfluous declarations on derived traits

as suggested: #422 (review)

- removes superfluous declarations on derived traits
@markdingram markdingram requested a review from a team January 13, 2021 20:35
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #423 (1913a5a) into master (f00c4c2) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   48.34%   48.32%   -0.02%     
==========================================
  Files          65       65              
  Lines        5502     5502              
==========================================
- Hits         2660     2659       -1     
- Misses       2842     2843       +1     
Impacted Files Coverage Δ
opentelemetry/src/metrics/meter.rs 50.00% <ø> (ø)
opentelemetry/src/metrics/registry.rs 0.00% <ø> (ø)
opentelemetry/src/sdk/metrics/mod.rs 0.00% <0.00%> (ø)
opentelemetry/src/metrics/noop.rs 20.00% <50.00%> (ø)
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 76.76% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f00c4c2...1913a5a. Read the comment docs.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@jtescher jtescher merged commit fc3175f into open-telemetry:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants