Sympy minus infinity doesn't convert to Sage #12345
Comments
|
Changed keywords from none to sd40.5 |
|
comment:1
Straightforward fix and test of the original case as an integral. |
|
comment:2
Umm, even without this patch I get Am I missing something? How is that an indirect doctest? That said, the integral works fine now and the tests pass. |
|
Reviewer: Karl-Dieter Crisman |
|
Author: Douglas McNeil |
|
comment:3
Ah, those were merely mirroring the +oo cases. Really they were only testing whether the negation worked; it was the integral test which was really verifying the success. However, we can test it explicitly by adding. which fails without the patch. Modified to incorporate this. |
|
comment:4
Positive review. |
|
Attachment: trac_12345_minusinfinity_sympyfication.patch.gz add |
|
Merged: sage-5.1.beta4 |
|
comment:7
I think this ticket is already fixed? |
|
Commit: |
37 tasks
Closed
vbraun
pushed a commit
that referenced
this issue
Mar 26, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> ### 📚 Description Made small edits to the PR template, making it concise and tidy overall. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on Depends on #12345: short description why this is a dependency Depends on #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35141 Reported by: Kwankyu Lee Reviewer(s): Kwankyu Lee, Tobias Diez
vbraun
pushed a commit
that referenced
this issue
Apr 6, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description Partial fix for pycodestyle E221, done using autopep8. E221 multiple spaces before operator <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35355 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
vbraun
pushed a commit
that referenced
this issue
Apr 6, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description The update #35184 broke the docs upload. Hopefully this is fixed with this PR. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35356 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Kwankyu Lee
vbraun
pushed a commit
that referenced
this issue
Apr 6, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> Follow-up from #35322. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35366 Reported by: Matthias Köppe Reviewer(s): Gonzalo Tornaría
vbraun
pushed a commit
that referenced
this issue
Apr 6, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description This is a follow-up on: - #35110 As preparation for #35322, which is changing more packages to implicit namespace packages, we remove `.all` imports from these packages throughout the Sage library. This is part of: - #29705 <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> - Depends on #35418 - Depends on #35358 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35372 Reported by: Matthias Köppe Reviewer(s): Gonzalo Tornaría
vbraun
pushed a commit
that referenced
this issue
Apr 6, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description openblas 0.3.22 is broken, see: - #35371 - scipy/scipy#18208 - OpenMathLib/OpenBLAS#3976 We reject it. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35377 Reported by: Matthias Köppe Reviewer(s): John H. Palmieri
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 24, 2025
Fix sagemath#39320 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#39309 Reported by: Rusydi H. Makarim Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 24, 2025
* It is not very well-known that doctest has magic features to ignore the ordering of `dict` and `set` (see for example sagemath#39413 (comment) ), I try to make it more discoverable. * Since the displayhook is in place (since 68b10e1), the `reproducible_repr` (added in e68d6eb) is mostly redundant. * Implement `_repr_pretty_` for `KeyConvertingDict` to make doctest deterministic. (based on the framework of sagemath#39027) There's a slight difference between `reproducible_repr` ordering (which always order by string representation) and this function (which tries first to order by element values, then by string representation), and the ordering of elements is reversed for multivariate polynomial ring (in `R.<x,y,z> = QQ[]`, `z < y < x`). However, it should still be deterministic. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39420 Reported by: user202729 Reviewer(s): Tobias Diez, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 24, 2025
…uares function
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#26107.
When n is a prime power the construction used in the
mutually_orthogonal_latin_squares function of latin_squares.py made all
n-1 possible Mutually Orthogonal Latin Squares (MOLS) no matter how many
were requested. This caused the function to take much longer than
required when n was large and the number of MOLS requested was small.
This was fixed by implementing a construction for prime powers n which
only creates the number of MOLS requested by the user. A reference was
added for this construction, and a doctest was added to verify it.
Several more doctests were changed as the function now returns different
MOLS when n is a prime power.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [X] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39483
Reported by: Caleb Van't Land
Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 24, 2025
…ete_log to give incorrect answer
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#38316 .
When the bounds provided to the discrete_log function did not contain
the correct answer the function would sometimes return an incorrect
answer.
This was fixed by adding the parameter 'check' to the function. This
parameter is True by default. If 'check' is True then the function
verifies the answer, returning it if it is correct and throwing a Value
Error if it is not. If 'check' is False then the function returns the
(possibly incorrect) answer without verifying it.
A doctest was added to verify that the function correctly throws an
error in a situation where it previously returned an incorrect answer.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [X] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39484
Reported by: Caleb Van't Land
Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 24, 2025
When you click on the "changes is ready!" button posted by github- actions, sometimes when a new code block is added/removed, a lot of irrelevant diff is shown. This pull request fixes it. Note: looks like the diff is against the last release, so we can't test this until after the next release. But the change looks simple enough that it can't have any bug… right. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39542 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 24, 2025
More category-generic methods. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39549 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 24, 2025
* src/sage/sat/solvers/dimacs.py: The particle "not" makes all the difference. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The patch should be self-explaining. When trying to run a SAT solver that is not available, I get an error message such as Could run 'kissat -q /tmp/tmp0r4t8342/tmp_j1161zu3', perhaps you need to add your SAT solver to $PATH? Clearly there is a "not" missing. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39551 Reported by: AndreasEnge Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 24, 2025
…ubalgebra
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#39225.
Previously the function in_subalgebra in
src/sage/rins/polynomial/multi_polynomial_libsingular.pyx returned True
or False, depending on whether the polynomial was present in the
provided subalgebra. When the parameter 'algorithm' was set to
'groebner' it would do this by generating a polynomial, but this
polynomial would not be made available to the user.
This function was enhanced by adding a key-word only argument
'certificate' to the function which defaults to False. When the value
provided for this argument evaluates to False the function behaves as
before. When the value provided evaluates to True and the Groebner
algorithm is used the function returns the polynomial generated by the
algorithm when it would have otherwise returned True, and returns None
when it would have otherwise returned False.
Additionally, if the value provided for the 'certificate' argument is a
string which evaluates to True then that string will be used to name the
variables in the generated polynomial.
The existing example for this function has been modified to test this
new functionality.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [X] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39555
Reported by: Caleb Van't Land
Reviewer(s): Caleb Van't Land, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 24, 2025
Apparently the test is introduced in sagemath#38824 and it's basically copied from another test below that is marked `random` ``` sage: E = EllipticCurve([-127^2,0]) sage: E.gens(use_database=False, algorithm='pari', pari_effort=4) # long time, random [(611429153205013185025/9492121848205441 : 15118836457596902442737698070880/924793900700594415341761 : 1)] ``` I don't know why this one isn't marked `# random` but I choose to keep checking the output but does it more carefully. Basically it has rank 1 so the generator is determined up to `± 1` and modulo torsion, so we just need to check `l[0] - a` or `l[0] + a` is in torsion. It's not clear why the test starts failing now. Maybe it's just random after all. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39567 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 24, 2025
this 2-line fix was missing on sagemath#39251 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39570 Reported by: Dima Pasechnik Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
…input is an instance of `StaticSparseBackend`
Many methods convert the input graph to a `short_digraph` for faster
operations. When the input is an instance of `StaticSparseBackend`, we
can directly get the `short_digraph` and so avoid the extra cost of the
conversion.
On the way, we fix some memory leaks as some instances of
`short_digraph` were not freed.
In a follow-up PR, we will do more in `distances_all_pairs.pyx`,
`hyperbolicity.pyx` and `traversals.pyx`.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39216
Reported by: David Coudert
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
Fix sagemath#39320 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#39309 Reported by: Rusydi H. Makarim Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
* It is not very well-known that doctest has magic features to ignore the ordering of `dict` and `set` (see for example sagemath#39413 (comment) ), I try to make it more discoverable. * Since the displayhook is in place (since 68b10e1), the `reproducible_repr` (added in e68d6eb) is mostly redundant. * Implement `_repr_pretty_` for `KeyConvertingDict` to make doctest deterministic. (based on the framework of sagemath#39027) There's a slight difference between `reproducible_repr` ordering (which always order by string representation) and this function (which tries first to order by element values, then by string representation), and the ordering of elements is reversed for multivariate polynomial ring (in `R.<x,y,z> = QQ[]`, `z < y < x`). However, it should still be deterministic. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39420 Reported by: user202729 Reviewer(s): Tobias Diez, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Minor revision, adding a bit of typing info, resorting imports and resolving some name collisions / overwrites. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39426 Reported by: Tobias Diez Reviewer(s): Sébastien Labbé
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> It's deprectaed since v8.7 and is no longer in use in sage, so should be safe to be deleted. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39427 Reported by: Tobias Diez Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
…uares function
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#26107.
When n is a prime power the construction used in the
mutually_orthogonal_latin_squares function of latin_squares.py made all
n-1 possible Mutually Orthogonal Latin Squares (MOLS) no matter how many
were requested. This caused the function to take much longer than
required when n was large and the number of MOLS requested was small.
This was fixed by implementing a construction for prime powers n which
only creates the number of MOLS requested by the user. A reference was
added for this construction, and a doctest was added to verify it.
Several more doctests were changed as the function now returns different
MOLS when n is a prime power.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [X] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39483
Reported by: Caleb Van't Land
Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
…ete_log to give incorrect answer
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#38316 .
When the bounds provided to the discrete_log function did not contain
the correct answer the function would sometimes return an incorrect
answer.
This was fixed by adding the parameter 'check' to the function. This
parameter is True by default. If 'check' is True then the function
verifies the answer, returning it if it is correct and throwing a Value
Error if it is not. If 'check' is False then the function returns the
(possibly incorrect) answer without verifying it.
A doctest was added to verify that the function correctly throws an
error in a situation where it previously returned an incorrect answer.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [X] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39484
Reported by: Caleb Van't Land
Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
…s, 1.7.0 and 0.7.1
Meson update is needed to deal with the issue found on sagemath#38749
A straightforward update. This will fix sagemath#39490
In particular, building of the latest cysignals on macOS might need
this.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39492
Reported by: Dima Pasechnik
Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
When you click on the "changes is ready!" button posted by github- actions, sometimes when a new code block is added/removed, a lot of irrelevant diff is shown. This pull request fixes it. Note: looks like the diff is against the last release, so we can't test this until after the next release. But the change looks simple enough that it can't have any bug… right. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39542 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
More category-generic methods. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39549 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
* src/sage/sat/solvers/dimacs.py: The particle "not" makes all the difference. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The patch should be self-explaining. When trying to run a SAT solver that is not available, I get an error message such as Could run 'kissat -q /tmp/tmp0r4t8342/tmp_j1161zu3', perhaps you need to add your SAT solver to $PATH? Clearly there is a "not" missing. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39551 Reported by: AndreasEnge Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
…ubalgebra
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#39225.
Previously the function in_subalgebra in
src/sage/rins/polynomial/multi_polynomial_libsingular.pyx returned True
or False, depending on whether the polynomial was present in the
provided subalgebra. When the parameter 'algorithm' was set to
'groebner' it would do this by generating a polynomial, but this
polynomial would not be made available to the user.
This function was enhanced by adding a key-word only argument
'certificate' to the function which defaults to False. When the value
provided for this argument evaluates to False the function behaves as
before. When the value provided evaluates to True and the Groebner
algorithm is used the function returns the polynomial generated by the
algorithm when it would have otherwise returned True, and returns None
when it would have otherwise returned False.
Additionally, if the value provided for the 'certificate' argument is a
string which evaluates to True then that string will be used to name the
variables in the generated polynomial.
The existing example for this function has been modified to test this
new functionality.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [X] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39555
Reported by: Caleb Van't Land
Reviewer(s): Caleb Van't Land, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
Apparently the test is introduced in sagemath#38824 and it's basically copied from another test below that is marked `random` ``` sage: E = EllipticCurve([-127^2,0]) sage: E.gens(use_database=False, algorithm='pari', pari_effort=4) # long time, random [(611429153205013185025/9492121848205441 : 15118836457596902442737698070880/924793900700594415341761 : 1)] ``` I don't know why this one isn't marked `# random` but I choose to keep checking the output but does it more carefully. Basically it has rank 1 so the generator is determined up to `± 1` and modulo torsion, so we just need to check `l[0] - a` or `l[0] + a` is in torsion. It's not clear why the test starts failing now. Maybe it's just random after all. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39567 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
this 2-line fix was missing on sagemath#39251 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39570 Reported by: Dima Pasechnik Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
…ples
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Contributes to sagemath#34120
As noted in the referenced issue. most instances of the "gens" method
return tuples, so the few instances of the method which return lists
instead should be modified to return tuples. This pull request handles
the following bullet points from the issue:
- `SymmetricReductionStrategy` in
`src/sage/rings/polynomial/symmetric_reduction.pyx`
- `EllipticCurve_number_field` in
`src/sage/schemes/elliptic_curves/ell_number_field.py`
- `SpecialCubicQuotientRing` in
`src/sage/schemes/hyperelliptic_curves/monsky_washnitzer.py`
In each case the gens method from the mentioned class has been modified
to return a tuple instead of a list and doctests have been updated
appropriately.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [X] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39572
Reported by: Caleb Van't Land
Reviewer(s): Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
…ver InfinityRing
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#34675
Previously, defining a multivariate polynomial ring over InfinityRing
would incorrectly result in an error. As mentioned in the comments under
the linked issue, this behaviour was fixed in version 10.3 but a doctest
was still needed.
This pull request adds the required doctest, verifying that the
statement `PolynomialRing(InfinityRing,2,'x')` correctly generates a
ring instead of throwing an error.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [X] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39573
Reported by: Caleb Van't Land
Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Feb 27, 2025
This is a follow up to sagemath#39251 This PR removes work around to support older python during the last two synchronization of sage_autodoc.py with upstream. python 3.9/3.10 support removal also enable us to move to a newer version of sphinx. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39577 Reported by: François Bissey Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Mar 1, 2025
we now have a new stable version of gmpy2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39364 Reported by: Dima Pasechnik Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Mar 1, 2025
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Many of the CI runs after a new release are failing, for months now, see eg https://github.com/sagemath/sage/actions/runs/12979684199/job/3621812 6145. Some of these failures are genuine (eg a certain package cannot be built on a certain system) and some others are due to constraints of the build system (eg running out of free space). Since there is very little point in senselessly burning energy, all runs that were failing for the last releases are disabled. Once the underlying issues are fixed, they can be easily be re-enabled. Moreover, the "minimal" runs where only a couple of systems packages are installed and most are build using sage are removed, keeping only the "standard" where all available system packages (corresponding to standard sage packages) are installed. New test run: https://github.com/tobiasdiez/sage/actions/runs/1319937223 2/job/36847711005 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#39251 (to resolve merge conflicts) <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39467 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Kwankyu Lee, Tobias Diez, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Mar 1, 2025
This bumps pillow and cffi to the latest versions. I had trouble building older ones on macOS M1 machine ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39571 Reported by: Dima Pasechnik Reviewer(s): David Coudert, Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See this ask.sagemath.org question for background.
CC: @certik @rwst
Component: symbolics
Keywords: sd40.5
Author: Douglas McNeil
Branch/Commit: u/akhi/sympy_minus_infinity_doesn_t_convert_to_sage @
52db42bReviewer: Karl-Dieter Crisman
Merged: sage-5.1.beta4
Issue created by migration from https://trac.sagemath.org/ticket/12345
The text was updated successfully, but these errors were encountered: