Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(documentation): remove categories from links WDOC-948 #4187

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

Louxor
Copy link
Contributor

@Louxor Louxor commented Jan 8, 2025

Description

Exceptions are handled at the start of the script, below each exception, you can find a example file where you can find it

relatives URLs -> updated with no categories in both markdown and in components

absolute URLs starting by http://www.scaleway.com/en/docs/ -> updated with no categories

All URLs to the scaleway website should be unchanged (example: http://www.scaleway.com/en/dedibox)

List of the updated categories:
CATEGORIES=(ai-data bare-metal compute console containers dedibox dedibox-console developer-tools environmental-footprint identity-and-access-management labs managed-databases managed-services network observability partners serverless storage)

Note :
dedibox-network is removed from the category list, because once dedibox-network/network is rewrited to dedibox-network, it becomes a conflict with the category name.
Most of the dedibox-network categories are exception, I added one for dedibox-network/ip-failover so that it becomes /ip-failover

@Louxor Louxor force-pushed the feat/remove-categories-from-links-WDOC-948 branch from 6eae474 to 4b21c04 Compare January 9, 2025 08:08
@Louxor Louxor added the do not merge PR that shouldn't be merged before a specific date (eg release) label Jan 9, 2025
@Louxor Louxor force-pushed the feat/remove-categories-from-links-WDOC-948 branch 3 times, most recently from 7298e3b to e6a3857 Compare January 9, 2025 17:21
@Slashgear Slashgear changed the title Feat(documentation): remove categories from links WDOC-948 feat(documentation): remove categories from links WDOC-948 Jan 10, 2025
@Louxor Louxor force-pushed the feat/remove-categories-from-links-WDOC-948 branch from e6a3857 to be8ce49 Compare January 10, 2025 09:55
@RoRoJ
Copy link
Contributor

RoRoJ commented Jan 10, 2025

There is one link in guidelines.mdx (at root level of content) that hasn't been updated, maybe because it's in a codeblock/table? Line 206 /en/docs/network/vpc/quickstart/

@RoRoJ
Copy link
Contributor

RoRoJ commented Jan 10, 2025

In faq/serverless-containers.mdx (line 50), faq/serverless-jobs.mdx (line 27) and faq/serverless-functions.mdx (line 46), there are still links to /serverless/sql-databases/ even though elsewhere this type of link has been modified to just /sql-databases

(On a separate subject, I question whether by losing the "serverless" part of the URL in this case the URL is not very logical, but I think that's a doc team discussion)

@Louxor Louxor force-pushed the feat/remove-categories-from-links-WDOC-948 branch from be8ce49 to 6dd425b Compare January 10, 2025 16:00
@Louxor Louxor marked this pull request as draft January 10, 2025 16:07
@github-actions github-actions bot added the status: draft Work in progress - do not merge or review label Jan 10, 2025
@Louxor Louxor force-pushed the feat/remove-categories-from-links-WDOC-948 branch 3 times, most recently from 32bc637 to a69a101 Compare January 15, 2025 10:51
@Louxor Louxor marked this pull request as ready for review January 15, 2025 12:47
@github-actions github-actions bot removed the status: draft Work in progress - do not merge or review label Jan 15, 2025
Copy link
Contributor

@Slashgear Slashgear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cela me parait bien.

Copy link
Contributor

@Slashgear Slashgear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Cela me parait bien 🎉

@Louxor Louxor force-pushed the feat/remove-categories-from-links-WDOC-948 branch 2 times, most recently from f411bbe to 828beca Compare January 20, 2025 15:24
@Louxor Louxor force-pushed the feat/remove-categories-from-links-WDOC-948 branch from 828beca to baf4a7f Compare January 20, 2025 15:27
@Louxor Louxor changed the base branch from main to fb-drop-categories January 20, 2025 15:27
@Louxor Louxor removed the do not merge PR that shouldn't be merged before a specific date (eg release) label Jan 20, 2025
@Louxor Louxor merged commit 2c3f926 into fb-drop-categories Jan 20, 2025
1 of 3 checks passed
@Louxor Louxor deleted the feat/remove-categories-from-links-WDOC-948 branch January 20, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants