Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret): add ephemeral policy configuration #2691

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Aug 7, 2024

Closes #2622

@Codelax Codelax added enhancement secret Managed Secret Manager issues, bugs and feature requests labels Aug 7, 2024
@Codelax Codelax self-assigned this Aug 7, 2024
@Codelax Codelax added the priority:high New features label Aug 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.02%. Comparing base (fe86049) to head (4d840c6).
Report is 141 commits behind head on master.

Files Patch % Lines
internal/services/secret/helpers.go 83.33% 2 Missing and 2 partials ⚠️
internal/services/secret/secret.go 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2691      +/-   ##
==========================================
- Coverage   71.43%   71.02%   -0.41%     
==========================================
  Files         277      334      +57     
  Lines       35875    33557    -2318     
==========================================
- Hits        25628    23835    -1793     
+ Misses       8028     7404     -624     
- Partials     2219     2318      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review August 7, 2024 09:35
@Codelax Codelax requested a review from remyleone as a code owner August 7, 2024 09:35
@Codelax Codelax marked this pull request as draft August 7, 2024 09:35
@Codelax Codelax marked this pull request as ready for review August 7, 2024 12:35
@Codelax Codelax force-pushed the feat/secret-ephemeral-policy branch from b993196 to 2e2b2bc Compare August 7, 2024 12:56
remyleone
remyleone previously approved these changes Aug 7, 2024
@remyleone remyleone added this pull request to the merge queue Aug 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 7, 2024
@Codelax Codelax added this pull request to the merge queue Aug 9, 2024
Merged via the queue into scaleway:master with commit d6965c4 Aug 9, 2024
43 checks passed
@Codelax Codelax deleted the feat/secret-ephemeral-policy branch August 9, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement priority:high New features secret Managed Secret Manager issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ephemeral policy for secret
4 participants