Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance_server): allow root_volume size update #2745

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Sep 17, 2024

Closes #2605

@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Sep 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 71.30%. Comparing base (fe86049) to head (87106bc).
Report is 193 commits behind head on master.

Files with missing lines Patch % Lines
...ternal/services/instance/helpers_instance_block.go 0.00% 20 Missing ⚠️
internal/services/instance/server.go 20.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2745      +/-   ##
==========================================
- Coverage   71.43%   71.30%   -0.13%     
==========================================
  Files         277      328      +51     
  Lines       35875    32919    -2956     
==========================================
- Hits        25628    23474    -2154     
+ Misses       8028     7198     -830     
- Partials     2219     2247      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review September 18, 2024 16:24
@Codelax Codelax force-pushed the feat/instance-server-root-volume-size-update branch 2 times, most recently from f18fded to 0ebfd37 Compare September 27, 2024 15:36
remyleone
remyleone previously approved these changes Oct 1, 2024
@Codelax Codelax force-pushed the feat/instance-server-root-volume-size-update branch from 0ebfd37 to 87106bc Compare October 1, 2024 08:32
@remyleone remyleone added this pull request to the merge queue Oct 1, 2024
Merged via the queue into scaleway:master with commit 82c9f80 Oct 1, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instance_server: resizing root volume results in replacement
3 participants