Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance_server): allow updating root_volume size for non l_ssd #2842

Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 6, 2024

Missed from #2745

@Codelax Codelax added bug instance Instance issues, bugs and feature requests labels Dec 6, 2024
@Codelax Codelax requested a review from remyleone as a code owner December 6, 2024 10:19
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.75%. Comparing base (fe86049) to head (6d0d70f).
Report is 240 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/instance/server.go 70.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2842      +/-   ##
==========================================
- Coverage   71.43%   67.75%   -3.69%     
==========================================
  Files         277      339      +62     
  Lines       35875    40109    +4234     
==========================================
+ Hits        25628    27174    +1546     
- Misses       8028    10621    +2593     
- Partials     2219     2314      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue Dec 6, 2024
Merged via the queue into scaleway:master with commit 3d9d4ff Dec 6, 2024
43 of 44 checks passed
@Codelax Codelax deleted the fix/instance-server-root-volume-size-forcenew branch December 6, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants