-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Legacy Text Template format section back to the Matching Guidelines #1026
Add Legacy Text Template format section back to the Matching Guidelines #1026
Conversation
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, easy to review in the rich diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source where we copy the whole annex should be https://github.com/spdx/license-list-XML/blob/main/DOCS/license-matching-guidelines-and-templates.md and not some ancient version from SPDXv2.
Use the same word as other examples: Signed-off-by: Arthit Suriyawongkul <[email protected]>
@zvr I was using v2.3.1 only because it's the latest version before v3.0 (which doesn't has this file). I was not aware of license-list-XML, so thanks for the pointer. I just have checked the Legacy Text Template format section from both sources (license-list-XML and v2.3.1), they are identical. |
Use `...` around special characters, as `\` will be interpreted as an escaping symbol - which made `\<\<\>\>` being displayed as `<<>>`. Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact have you checked that the complete file is identical (not only the last section) ? |
Done. Every sections in the source of license-list-XML and v2.3.1 are identical. Through the scan, found two spots in "HTTP Protocol" section that may need changes:
Also one typo found (introduced be myself during the link format conversion), will fix that. |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@zvr - now I'm confused... are we keeping the matching guidelines in the license list repo? we definitely should not have them in two places! |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
standardLicenseTemplate and standardAdditionTemplate still need the Legacy Text Template.
See discussion in spdx/spdx-3-model#747 (comment)
https://github.com/spdx/spdx-spec/blob/development/v2.3.1/chapters/license-matching-guidelines-and-templates.mdhttps://github.com/spdx/license-list-XML/blob/main/DOCS/license-matching-guidelines-and-templates.md