-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing anchors B.6.4, B.15.3; Swap HTTP cases #2537
Conversation
bact
commented
Aug 7, 2024
•
edited
Loading
edited
- Remove "Annex" in the title, re-run heading numbering
- See comments starting from here
- Add missing anchors B.6.4 and B.15.3 (now 5.4 and 14.3, after re-numbering)
- Put B.15.2 (14.2) anchor to the right heading
- Make link to SPDX License List
- Add internal links to guidelines
- Put some special characters example inside `...` to differentiate
- HTTP cases in B.14.1 and B.14.2 (13.1 and 13.2)
- Protocol names (HTTP and HTTPS) should be in UPPERCASE (they are initialisms)
- The schema names at the first part of URL ("http://" and "https://", which will be the actual texts to be compared) should be in lowercase -- see https://www.rfc-editor.org/rfc/rfc9110.html#name-http-related-uri-schemes
- Also make link to SPDX License List - Put some special characters example inside `...` to differentiate Signed-off-by: Arthit Suriyawongkul <[email protected]>
Use "repository" as everywhere else. Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are making changes, you might as well remove all the numbering; this is not an "Annex" here
Please explain more please. Do you mean to remove all the existing heading numbering? |
Also in the last line, EXAMPLE: -> For example:, to match the wording used by other guideline sections. Signed-off-by: Arthit Suriyawongkul <[email protected]>
@zvr just to make sure before making changes, do you mean to
Thank you |
Yes, the whole text can be simplified to something like:
|
Also remove "B" numbering Signed-off-by: Arthit Suriyawongkul <[email protected]>
Use "guideline(s)" label for internal link within the doc Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@jlovejoy on HTTP, please see this comment #2537 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bact and all!