Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP casing + update links to license-list-XML repo #1071

Merged

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 13, 2024

SPDX License List matching guidelines and templates

This will fix #1068 and resolve #1070

- Use "HTTP" and "HTTPS" for protocol names
- Use "http://" and "https://" for URI schemes of URL
- Use "SPDX License List" caps style as it is a proper noun and stylized like that consistently in https://spdx.org/licenses/
- Keep page title and navigation bar title match
- Use a versioned link of resources from license-list-XML repo

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested review from goneall and swinslow August 13, 2024 17:25
@bact bact added this to the 3.0.1 milestone Aug 13, 2024
@bact
Copy link
Collaborator Author

bact commented Aug 13, 2024

See @swinslow comments in #1070 (comment)

@bact
Copy link
Collaborator Author

bact commented Aug 13, 2024

@swinslow If v3.25.0 will eventually available soon in these exact URLs:

I think it's possible to put them in advance to the spec. I'm happy to modify this PR for that.
(and also update licenseXml, which is currently already linked to v3.24.0 by spdx/spdx-3-model#819)

But apart from the URLs, do you like to changes anything here please? Thank you.

@bact bact requested a review from kestewart August 14, 2024 07:20
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @bact

@goneall goneall merged commit a8425e9 into spdx:development/v3.0.1 Aug 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants