Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/hooks: user contact method delete dialog #1024

Merged
merged 5 commits into from
Nov 18, 2020
Merged

ui/hooks: user contact method delete dialog #1024

merged 5 commits into from
Nov 18, 2020

Conversation

alejandra-martinez
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts UserContactMethodDeleteDialog.js to use hooks.

Which issue(s) this PR fixes:
Part of #923

Forfold
Forfold requested changes Nov 12, 2020
View reviewed changes
@alejandra-martinez alejandra-martinez mentioned this pull request Nov 16, 2020
Closed
dctalbot
dctalbot approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! In the future, we should use a more descriptive branch name so it's clear what component is being worked on

@alejandra-martinez alejandra-martinez merged commit 40fb24c into master Nov 18, 2020
@alejandra-martinez alejandra-martinez deleted the class-to-hook branch November 18, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@dctalbot dctalbot dctalbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alejandra-martinez @Forfold @dctalbot @mastercactapus