Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: convert remaining class components to hooks #923

Closed
mastercactapus opened this issue Oct 7, 2020 · 19 comments
Closed

ui: convert remaining class components to hooks #923

mastercactapus opened this issue Oct 7, 2020 · 19 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed in progress javascript Pull requests that update Javascript code

Comments

@mastercactapus
Copy link
Member

mastercactapus commented Oct 7, 2020 •
edited by KatieMSB
Loading

This is an issue to track progress on converting the remaining class components to React hooks.

They should be converted in javascript for review purposes (continue to use PropTypes). A separate issue will be created for converting to typescript if needed.

Decorators should also be removed. There is usually a corresponding hook to achieve the same functionality.
For example, a class component using @withWidth and props.width can be written as a functional component that uses const width = useWidth()

Please keep PR size small, and run tests locally, to help speed up reviews.
@mastercactapus mastercactapus added enhancement New feature or request good first issue Good for newcomers labels Oct 7, 2020
@Patil2099
Copy link

Can I work on this @mastercactapus?

@mastercactapus
Copy link
Member Author

@Patil2099 absolutely!

I think what would be easiest is if you had a file or two in mind from the list and I can put your name by it so others know it's being worked on.

This was referenced Nov 5, 2020
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 9, 2020
Merged
Merged
Closed
@pnengchu pnengchu mentioned this issue Nov 10, 2020
Merged
7 tasks
@KatieMSB KatieMSB mentioned this issue Nov 10, 2020
Merged
7 tasks
@dctalbot dctalbot mentioned this issue Nov 10, 2020
Merged
7 tasks
@KatieMSB KatieMSB mentioned this issue Nov 11, 2020
Merged
7 tasks
@Forfold Forfold added help wanted Extra attention is needed in progress javascript Pull requests that update Javascript code and removed enhancement New feature or request labels Nov 11, 2020
This was referenced Nov 11, 2020
Merged
Merged
@pnengchu pnengchu mentioned this issue Nov 11, 2020
Merged
5 tasks
@dctalbot dctalbot mentioned this issue Nov 11, 2020
Merged
7 tasks
This was referenced Nov 12, 2020
Merged
Merged
@alejandra-martinez alejandra-martinez mentioned this issue Nov 12, 2020
Merged
7 tasks
This was referenced Jul 14, 2021
Merged
Merged
@Voninkazo Voninkazo mentioned this issue Jul 14, 2021
Merged
7 tasks
@voromahery voromahery mentioned this issue Jul 14, 2021
Merged
7 tasks
@Voninkazo Voninkazo mentioned this issue Jul 14, 2021
Merged
7 tasks
@Voninkazo
Copy link
Contributor

@Forfold We've worked on those tasks above but our names are not there yet, please add our names next to each task for people to know. Thanks :)

@voromahery voromahery mentioned this issue Jul 17, 2021
Merged
7 tasks
@Voninkazo Voninkazo mentioned this issue Jul 19, 2021
Merged
7 tasks
@voromahery voromahery mentioned this issue Jul 23, 2021
Merged
7 tasks
@Voninkazo Voninkazo mentioned this issue Jul 23, 2021
Closed
7 tasks
This was referenced Aug 11, 2021
Merged
Merged
@Voninkazo Voninkazo mentioned this issue Aug 11, 2021
Closed
7 tasks
@starjardin starjardin mentioned this issue Aug 13, 2021
Closed
7 tasks
@Voninkazo Voninkazo mentioned this issue Aug 13, 2021
Closed
7 tasks
This was referenced Sep 7, 2021
Merged
Merged
@spencerpauly spencerpauly unpinned this issue Oct 6, 2021
@stale
Copy link

stale bot commented May 31, 2022

This issue has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale This is inactive label May 31, 2022
@stale stale bot removed the stale This is inactive label Jun 7, 2022
@Forfold Forfold mentioned this issue Jun 7, 2022
Merged
7 tasks
@nataliekorzh nataliekorzh mentioned this issue Oct 28, 2022
Merged
7 tasks
@stale
Copy link

stale bot commented Apr 26, 2023

This issue has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale This is inactive label Apr 26, 2023
@Forfold Forfold removed the stale This is inactive label Apr 26, 2023
This was referenced May 23, 2023
Merged
Closed
@mastercactapus
Copy link
Member Author

Closing as complete, the remaining work is captured in #3043 and #3044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed in progress javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@mastercactapus @kanish671 @Forfold @dctalbot @m17ch @Patil2099 @rinonTen @Voninkazo @voromahery