Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/hooks: policy step delete dialog #1042

Merged
merged 2 commits into from
Nov 23, 2020
Merged

ui/hooks: policy step delete dialog #1042

merged 2 commits into from
Nov 23, 2020

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts PolicyStepDeleteDialog.js to use hooks.

Which issue(s) this PR fixes:
Part of #923

@KatieMSB KatieMSB mentioned this pull request Nov 18, 2020
Closed
Forfold
Forfold previously approved these changes Nov 18, 2020
View reviewed changes
@KatieMSB KatieMSB merged commit 01504d8 into master Nov 23, 2020
@KatieMSB KatieMSB deleted the hooks-policy-step-delete-dialog branch November 23, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@dctalbot dctalbot dctalbot approved these changes

@Forfold Forfold Forfold left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KatieMSB @mastercactapus @Forfold @dctalbot