Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/hooks: count down #1100

Merged
merged 1 commit into from
Dec 10, 2020
Merged

ui/hooks: count down #1100

merged 1 commit into from
Dec 10, 2020

Conversation

dctalbot
Copy link
Contributor

@dctalbot dctalbot commented Dec 8, 2020

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Use hooks in CountDown.js

Which issue(s) this PR fixes:
Part of #923

@dctalbot dctalbot mentioned this pull request Dec 8, 2020
Closed
m17ch
m17ch approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dctalbot dctalbot merged commit 3757a6f into master Dec 10, 2020
@dctalbot dctalbot deleted the hooks-countdown branch December 10, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@m17ch m17ch m17ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dctalbot @mastercactapus @m17ch