Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/hooks: RotationAddUserDialog #1452

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

kanish671
Copy link
Contributor

@kanish671 kanish671 commented Apr 23, 2021

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Refactored web/src/app/rotations/RotationAddUserDialog.js to use hooks.

Which issue(s) this PR fixes:
Part of #923

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for making my recommended changes!

@dctalbot dctalbot merged commit bf44766 into target:master Apr 28, 2021
@kanish671 kanish671 deleted the hooks/rotation-add-user-dialog branch April 28, 2021 15:32
@dctalbot dctalbot changed the title Refactoring RotationAddUserDialog to use hooks ui/hooks: RotationAddUserDialog Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants