New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/hooks: RotationUserDeleteDialog #1455

Merged

Forfold merged 1 commit into target:master from kanish671:hooks/rotation-user-delete-dialog

Apr 23, 2021

Contributor

kanish671 commented Apr 23, 2021

Identified the issue which this PR solves.
Read the CONTRIBUTING document.
Code builds clean without any errors or warnings.
Added appropriate tests for any new functionality.
All new and existing tests passed.
Added comments in the code, where necessary.
Ran make check to catch common errors. Fixed any that came up.

Description:
Refactored web/src/app/rotations/RotationUserDeleteDialog.js to use hooks.

Which issue(s) this PR fixes:
Part of #923


          Refactoring RotationUserDeleteDialog to use hooks

4e68b5f

mastercactapus approved these changes

View reviewed changes

Forfold approved these changes

View reviewed changes

Contributor

Forfold left a comment

LGTM

Forfold merged commit e570c8b into target:master

dctalbot mentioned this pull request

ui: convert remaining class components to hooks #923

Closed

kanish671 deleted the hooks/rotation-user-delete-dialog branch

April 27, 2021 02:41

dctalbot changed the title ~~Refactoring RotationUserDeleteDialog to use hooks~~ ui/hooks: RotationUserDeleteDialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet