ui/hooks: ScheduleRuleEditDialog #1792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dctalbot
suggested changes
Sep 9, 2021
|
|
||
| shouldComponentUpdate(nextProps, nextState) { | ||
| if (this.state !== nextState) return true | ||
| function shouldComponentUpdate(nextState) { |
There was a problem hiding this comment.
shouldComponentUpdate is a React class lifecycle method. Take a look at the documentation here for some notes about how to implement it in a functional component
|
Closing due to inactivity. Please feel free to reopen with the suggested changes if you are interested in continuing this work. Thanks! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Refactoring ScheduleRuleEditDialog class component to a functional.
Which issue(s) this PR fixes:
Part of #923