Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/hooks: google analytics #1884

Merged
merged 4 commits into from
Sep 9, 2021
Merged

ui/hooks: google analytics #1884

merged 4 commits into from
Sep 9, 2021

Conversation

dctalbot
Copy link
Contributor

@dctalbot dctalbot commented Sep 7, 2021

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR converts GoogleAnalytics to a functional component

Which issue(s) this PR fixes:
Part of #923

@dctalbot dctalbot mentioned this pull request Sep 7, 2021
Closed
m17ch
m17ch approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@dctalbot dctalbot merged commit 4acef66 into master Sep 9, 2021
@dctalbot dctalbot deleted the hooks-ga branch September 9, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold left review comments

@m17ch m17ch m17ch approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dctalbot @Forfold @m17ch @KatieMSB