-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status updates: switch to per-contact-method behavior #2824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to run make regendb
to get things working- not sure if this is expected with the new migration.
I also got an unexpected error when attempting to enable status updates for my SMS contact method via the UI:
AuthSource="SourceTypeAuthProvider{c7d64ef8-309a-40a4-bf75-9cee7ce3fe04}" AuthUserID=33d00c33-04ce-44c8-b729-e0f114257d27 RequestID=da7562d1-8f9c-4734-bde1-1d1171144d8d error="input: updateUserContactMethod sql: expected 4 arguments, got 3" host=sendit.dev.target.goalert.me http_method=POST http_proto=HTTP/1.1 referer="https://sendit.dev.target.goalert.me/cook/users/33d00c33-04ce-44c8-b729-e0f114257d27" remote_addr="127.0.0.1:52093" uri=/cook/api/graphql x_forwarded_for="98.246.168.48, 136.226.55.2, 35.190.115.218, 35.191.10.92, yamux" x_forwarded_host=
@Forfold For the The SQL error was a bug; I pushed a fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description:
This PR changes the behavior of status updates to be a per-contact-method setting, instead of a global user-level setting.
Which issue(s) this PR fixes:
Related to #2712
Screenshots:

Describe any introduced user-facing changes:
Describe any introduced API changes:
statusUpdates
field onUserContactMethod
andenableStatusUpdates
onUpdateUserContactMethodInput
Additional Context
auth_subjects
Slack DM functionality is behind a feature flag, test with
make start EXPERIMENTAL=slack-dm