fix slack dm status updates #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes leftover code around
alert_status_log_contact_method_id, causing problems with status updates.A smoke test was added that reproduces the issue, fails before the fix, and passes after.
The status update cancel test was also updated to use the new API.
Which issue(s) this PR fixes:
Fixes #2889
Describe any introduced API changes:
The deprecated status method CM ID fields no longer do anything and always return an empty string.
Additional Info:
Root issue: Previous to the recent status update change in #2824, changing the
alert_status_log_contact_method_idin the user table would retroactively update any pending status update messages to the new contact method.With the new behavior, subscriptions are now per contact method. When a user previously had a contact method set up for status updates (before the update), all individual updates would still mistakenly be redirected to the original.
This meant that status updates for Slack would be redirected to the user's SMS, for instance. If status updates were disabled for the SMS contact method (in the new format), then the message would be canceled/deleted, which left no trace of why status updates weren't being sent to Slack.
This issue doesn't only impact Slack, but it was the most common/visible manifestation.