Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: update user-group membership for configured schedules #2926

Merged
merged 8 commits into from
Apr 26, 2023
Merged

slack: update user-group membership for configured schedules #2926

merged 8 commits into from
Apr 26, 2023

Conversation

mastercactapus
Copy link
Member

Description:
This PR adds the calls to update group membership, with channel message as fallback for the slack-ug experimental flag.

Which issue(s) this PR fixes:
Part of #1228

Out of Scope:

  • The link action button for the missing user case is left as a TODO

@github-actions github-actions bot added the size/l label Apr 4, 2023
AlaricWhitney
AlaricWhitney previously requested changes Apr 6, 2023
View reviewed changes
@Forfold Forfold mentioned this pull request Apr 11, 2023
Merged
Forfold
Forfold approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed then functionally tested the following scenarios with a user group enabled for notifications, LGTM:

  • No users linked
  • All users in update are linked
  • Some users are linked
  • Removing all linked users, seeing error message that it remains as-is

@KatieMSB KatieMSB requested a review from AlaricWhitney April 26, 2023 19:38
@mastercactapus mastercactapus dismissed AlaricWhitney’s stale review April 26, 2023 21:13

last response was 3 weeks ago, dismissing to get this unstuck and start updating the UI component

@mastercactapus mastercactapus merged commit a9bd48c into master Apr 26, 2023
@mastercactapus mastercactapus deleted the slack-ug-update branch April 26, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

@AlaricWhitney AlaricWhitney Awaiting requested review from AlaricWhitney

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mastercactapus @Forfold @AlaricWhitney @KatieMSB