ui: add slack user groups to on call notifications #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently includes changes from #2926. Let's get that merged first. |
AlaricWhitney
requested changes
Apr 18, 2023
Co-authored-by: Alaric Whitney <[email protected]>
Co-authored-by: Alaric Whitney <[email protected]>
|
Switching this to be a draft while blocked, #2926 has the API changes that need to be merged first. |
mastercactapus
requested changes
Apr 26, 2023
There was a problem hiding this comment.
This is still visible without the feature flag set, let's add a guard around that. EP step UI has an example of how to do this for webhooks.
Also, couple of layout questions:
- Should we move the input fields below the notification option? I feel the input should follow the context. Also, we may be adding webhook support here soon, so it will help prepare for more noise.
- Can we put a checkbox in for the user group and conditionally show the input field? I think that might reduce noise in the form while still keeping it clear how to opt-in to the new feature.
mastercactapus
approved these changes
May 1, 2023
AlaricWhitney
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces the ability to create an on-call notification rule that simultaneously keeps a slack user group in sync with the list of GoAlert on-call users
Which issue(s) this PR fixes:
Part of #1228
EDIT: not marking as closed until feature flag is removed
Screenshots:
