Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map: rationalize fonts and sprites #10627

Closed
8 of 14 tasks
Tristramg opened this issue Feb 3, 2025 · 0 comments · Fixed by #10788
Closed
8 of 14 tasks

Map: rationalize fonts and sprites #10627

Tristramg opened this issue Feb 3, 2025 · 0 comments · Fixed by #10788
Assignees
@Tristramg

Comments

@Tristramg
Copy link
Contributor

Tristramg commented Feb 3, 2025 •
edited
Loading

Description and goal

Currently some fonts and sprites used on the map depend on an external server. We would like integrate all those assets here to avoid an external dependency.

This is also an occasion to check on what fonts we depend to rationalize them.

TODO:

  • reduce the number of used fonts (in particular switch from Open Sans to Roboto)
  • integrate svgs and sprites from https://github.com/nicolaswurtz/signalisation-rfn-svg/
    • Filter to only needed icons (no signals, no bluescreen)
    • Generate the sprite atlas
    • use the assets in the front
    • optional: switch to spreet for smaller atlases
    • optional: switch to webp for smaller atlases
  • fonts
    • save the .pbf fonts in editoast/assets
    • serve the fonts through editoast (in a similar manner as the sprites)
    • optional: consider pre-compressing the binary .pbf files
    • probably better not: remove unused/empty unicode blocks
    • use the fonts
    • probably later: change the fonts to plex to be coherent with the rest of the app

Acceptance criteria

There should be no call to an external server for fonts and sprites
@Tristramg Tristramg self-assigned this Feb 3, 2025
Tristramg added a commit that referenced this issue Feb 3, 2025
@Tristramg
front: map: use only Roboto not OpenSans
97ed468 
This reduces the number of fonts

Ref #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 3, 2025
@Tristramg
front: map: use only Roboto not OpenSans
577e90e 
This reduces the number of fonts

Ref #10627

Signed-off-by: Tristram Gräbener <[email protected]>
@Tristramg Tristramg mentioned this issue Feb 3, 2025
Merged
Tristramg added a commit that referenced this issue Feb 3, 2025
@Tristramg
front: map: use only Roboto not OpenSans
fffd948 
This reduces the number of fonts

Ref #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 4, 2025
@Tristramg
front: map: use only Roboto not OpenSans
d22309a 
This reduces the number of fonts

Ref #10627

Signed-off-by: Tristram Gräbener <[email protected]>
@Tristramg Tristramg mentioned this issue Feb 4, 2025
Merged
Tristramg added a commit that referenced this issue Feb 12, 2025
@Tristramg
front: map: use only Roboto not OpenSans
03c38b4 
This reduces the number of fonts

Ref #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 12, 2025
@Tristramg
front: map: use only Roboto not OpenSans
233eae7 
This reduces the number of fonts

Ref #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 12, 2025
@Tristramg
front: map: use only Roboto not OpenSans
7521d36 
This reduces the number of fonts

Ref #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 12, 2025
@Tristramg
editoast: front: host fonts for the map in editoast
5514494 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>
@Tristramg Tristramg mentioned this issue Feb 12, 2025
Merged
Tristramg added a commit that referenced this issue Feb 13, 2025
@Tristramg
editoast: front: host fonts for the map in editoast
ab4f0e8 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 13, 2025
@Tristramg
editoast: front: host fonts for the map in editoast
82c4a8a 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 13, 2025
@Tristramg
editoast: front: host fonts for the map in editoast
b8bae1b 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 13, 2025
@Tristramg
editoast: front: host fonts for the map in editoast
1e4ba70 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 13, 2025
@Tristramg
editoast: front: host fonts for the map in editoast
f493809 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Feb 14, 2025
@Tristramg
front: map: use only Roboto not OpenSans
82b3a4c 
This reduces the number of fonts

Ref #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 14, 2025
@Tristramg
editoast: front: host fonts for the map in editoast
fe75ed9 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>

editoast: front: use the fonts served by editoast in the maps


Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 16, 2025
@Tristramg
editoast: front: host fonts for the map in editoast
b0bf5ab 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>

editoast: front: use the fonts served by editoast in the maps


Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 17, 2025
@Tristramg
editoast: front: host fonts for the map in editoast
a04806b 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>

editoast: front: use the fonts served by editoast in the maps


Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 17, 2025
@Tristramg
editoast: host fonts for the map in editoast
0bcf19f 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>

editoast: front: use the fonts served by editoast in the maps


Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg added a commit that referenced this issue Feb 17, 2025
@Tristramg
editoast: host fonts for the map in editoast
a3f710a 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Feb 17, 2025
@Tristramg
editoast: host fonts for the map in editoast
cad7b7b 
The glyphs are generated during the build step

Closes #10627

Signed-off-by: Tristram Gräbener <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tristramg Tristramg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editoast, front: host fonts for the map in editoast OpenRailAssociation/osrd
1 participant
@Tristramg