Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: map: use only Roboto not OpenSans #10628

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

Tristramg
Copy link
Contributor

This reduces the number of fonts

Ref #10627

@Tristramg Tristramg requested a review from a team as a code owner February 3, 2025 14:30
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.83%. Comparing base (3f83ed4) to head (7521d36).
Report is 43 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10628      +/-   ##
==========================================
- Coverage   81.83%   81.83%   -0.01%     
==========================================
  Files        1081     1081              
  Lines      106882   106882              
  Branches      729      729              
==========================================
- Hits        87469    87465       -4     
- Misses      19372    19376       +4     
  Partials       41       41              
Flag Coverage Δ
editoast 74.31% <ø> (-0.02%) ⬇️
front 89.38% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tristramg Tristramg force-pushed the from_opensans_to_roboto branch from 577e90e to fffd948 Compare February 3, 2025 16:09
@emersion
Copy link
Member

emersion commented Feb 4, 2025

Just to double check: is @thibautsailly aware of this change?

@Tristramg Tristramg force-pushed the from_opensans_to_roboto branch from fffd948 to d22309a Compare February 4, 2025 10:56
@Tristramg Tristramg self-assigned this Feb 5, 2025
@thibautsailly
Copy link

Just to double check: is @thibautsailly aware of this change?

Yes, no problem. I will resume work on the map themes later and will make propositions for fonts then. For now Roboto is the easiest way to go.

@Tristramg Tristramg force-pushed the from_opensans_to_roboto branch 2 times, most recently from 03c38b4 to 233eae7 Compare February 12, 2025 15:28
This reduces the number of fonts

Ref #10627

Signed-off-by: Tristram Gräbener <[email protected]>
@Tristramg Tristramg force-pushed the from_opensans_to_roboto branch from 233eae7 to 7521d36 Compare February 12, 2025 15:34
@Tristramg Tristramg requested a review from emersion February 12, 2025 15:34
@Tristramg
Copy link
Contributor Author

@emersion now that the blueprint has been removed, roboto was only used in dark mode, so I suppose it was just forgotten when migrating to roboto

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tristramg Tristramg added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@Tristramg Tristramg added this pull request to the merge queue Feb 14, 2025
Merged via the queue into dev with commit 82b3a4c Feb 14, 2025
27 checks passed
@Tristramg Tristramg deleted the from_opensans_to_roboto branch February 14, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants