-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: map: use only Roboto not OpenSans #10628
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10628 +/- ##
==========================================
- Coverage 81.83% 81.83% -0.01%
==========================================
Files 1081 1081
Lines 106882 106882
Branches 729 729
==========================================
- Hits 87469 87465 -4
- Misses 19372 19376 +4
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
577e90e
to
fffd948
Compare
Just to double check: is @thibautsailly aware of this change? |
fffd948
to
d22309a
Compare
Yes, no problem. I will resume work on the map themes later and will make propositions for fonts then. For now Roboto is the easiest way to go. |
03c38b4
to
233eae7
Compare
This reduces the number of fonts Ref #10627 Signed-off-by: Tristram Gräbener <[email protected]>
233eae7
to
7521d36
Compare
@emersion now that the blueprint has been removed, roboto was only used in dark mode, so I suppose it was just forgotten when migrating to roboto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This reduces the number of fonts
Ref #10627