Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: Editor crash with theme other than the "normal" one #5806

Closed
sim51 opened this issue Nov 22, 2023 · 1 comment · Fixed by #5823
Closed

front: Editor crash with theme other than the "normal" one #5806

sim51 opened this issue Nov 22, 2023 · 1 comment · Fixed by #5823
Assignees
@sim51
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:infra-editor Infra Edition severity:critical Critical severity bug

Comments

@sim51
Copy link
Contributor

sim51 commented Nov 22, 2023

What happened?

Editor crash directly

image

What did you expect to happen?

Should work

How can we reproduce it (as minimally and precisely as possible)?

  • Go to the ref map
  • Open the map settings
  • Select the "blueprint" theme
  • go to the editor

The issue comes from themes where some colors (the one uses for the error layer) are missing

What operating system, browser and environment are you using?

  • Browser: Firefox v109
  • OS: Nixos v22.11
  • Env: Local

OSRD version (top right corner Account button > Informations)

90dff68
@sim51 sim51 added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules severity:critical Critical severity bug module:infra-editor Infra Edition labels Nov 22, 2023
@sim51 sim51 self-assigned this Nov 23, 2023
sim51 added a commit that referenced this issue Nov 23, 2023
@sim51
front: editor - be able to select a theme
db60237 
Close #5806 & #5821

- Adding the MapSettingsMapStyle component in the editor settings, and for
that I changed a little bit the CSS.
- sync labels of data and map layer in the editor with the one on the map.
- adding missing color to some theme (see #5821)
@sim51 sim51 mentioned this issue Nov 23, 2023
Merged
sim51 added a commit that referenced this issue Nov 23, 2023
@sim51
front: editor - be able to select a theme
25ecf3b 
Close #5806 & #5821

- Adding the MapSettingsMapStyle component in the editor settings, and for
that I changed a little bit the CSS.
- sync labels of data and map layer in the editor with the one on the map.
- adding missing color to some theme (see #5821)
@sim51
Copy link
Contributor Author

sim51 commented Nov 23, 2023

Fixed in #5823 5823

@sim51 sim51 closed this as completed Nov 23, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 23, 2023
@sim51
front: editor - be able to select a theme
4816d8b 
Close #5806 & #5821

- Adding the MapSettingsMapStyle component in the editor settings, and for
that I changed a little bit the CSS.
- sync labels of data and map layer in the editor with the one on the map.
- adding missing color to some theme (see #5821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sim51 sim51

Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:infra-editor Infra Edition severity:critical Critical severity bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

front: editor - be able to select a theme OpenRailAssociation/osrd
1 participant
@sim51