Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: ts2: adapt fuzzer #7324

Merged
merged 3 commits into from
May 28, 2024
Merged

tests: ts2: adapt fuzzer #7324

merged 3 commits into from
May 28, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Apr 26, 2024

  1. Add a new version of the fuzzer script, calling only timetable v2 versions of the endpoints
  2. Add a new version of the script loading the fuzzer files to reproduce the test cases

The old version should be deleted at the same time as the old endpoints.

One difference compared to the v1 is that we don't ignore any error, we don't ignore when the path doesn't exist or when the margins are impossible. It's not necessarily a problem (we don't risk ignoring an actual issue), but we need to filter through the results manually. And we can't run the script directly in the test suite anymore.

@eckter eckter changed the base branch from dev to alch/ts2-signal_projection April 26, 2024 08:25
@Erashin Erashin force-pushed the alch/ts2-signal_projection branch from d7fefe8 to bbc1db0 Compare April 26, 2024 08:27
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 37.04819% with 209 lines in your changes are missing coverage. Please review.

Project coverage is 18.64%. Comparing base (da73cf0) to head (d0ac9a5).

Files Patch % Lines
tests/fuzzer/fuzzer_v2.py 28.62% 192 Missing ⚠️
tests/tests/test_regressions_v2.py 74.19% 16 Missing ⚠️
tests/fuzzer/fuzzer.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7324       +/-   ##
=============================================
- Coverage     29.34%   18.64%   -10.71%     
  Complexity     2012     2012               
=============================================
  Files          1198      928      -270     
  Lines        147045   118052    -28993     
  Branches       2889     2889               
=============================================
- Hits          43156    22009    -21147     
+ Misses       102188    94342     -7846     
  Partials       1701     1701               
Flag Coverage Δ
core 75.08% <ø> (ø)
editoast ?
front 9.76% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 71.78% <37.04%> (-12.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin force-pushed the alch/ts2-signal_projection branch 2 times, most recently from 923d2d8 to 5351795 Compare April 26, 2024 09:46
@flomonster flomonster force-pushed the alch/ts2-signal_projection branch 3 times, most recently from 73db534 to 8f3e8ed Compare April 26, 2024 14:40
Base automatically changed from alch/ts2-signal_projection to dev April 26, 2024 16:13
@eckter eckter linked an issue Apr 30, 2024 that may be closed by this pull request
@eckter eckter force-pushed the ech/ts2-fuzzer branch 12 times, most recently from 0640510 to 95a58bb Compare May 6, 2024 12:29
@eckter eckter force-pushed the ech/ts2-fuzzer branch 6 times, most recently from 6dbe794 to 579edcd Compare May 16, 2024 08:43
@eckter eckter force-pushed the ech/ts2-fuzzer branch 2 times, most recently from 73cbf68 to 0eecd94 Compare May 21, 2024 07:52
@eckter eckter force-pushed the ech/ts2-fuzzer branch 3 times, most recently from 18b0866 to 326a39d Compare May 21, 2024 14:43
@eckter eckter marked this pull request as ready for review May 21, 2024 14:45
@eckter eckter requested a review from a team as a code owner May 21, 2024 14:45
@eckter eckter requested a review from shenriotpro May 21, 2024 14:45
@eckter eckter force-pushed the ech/ts2-fuzzer branch 2 times, most recently from dbf756d to 8895d41 Compare May 23, 2024 09:42
@eckter eckter marked this pull request as draft May 27, 2024 13:12
@eckter eckter marked this pull request as ready for review May 27, 2024 13:39
@eckter eckter requested a review from shenriotpro May 28, 2024 07:34
@eckter eckter enabled auto-merge May 28, 2024 12:14
@eckter eckter added this pull request to the merge queue May 28, 2024
Merged via the queue into dev with commit 5613755 May 28, 2024
17 checks passed
@eckter eckter deleted the ech/ts2-fuzzer branch May 28, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS2: adapt fuzzer
4 participants